Discourage the use of controllers as services #6611
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,31 +4,40 @@ | |||
| How to Define Controllers as Services | |||
| ===================================== | |||
|
|
|||
| .. caution:: | |||
|
|
|||
| Defining controllers as services is **not officially recommended** by Symfony. | |||
There was a problem hiding this comment.
In my opinion it's needed for newcomers.
|
Could we move this PR forward? @wouterj if you like we can reword the caution note, but I'd like to clearly say "don't use this ... unless you know what you are doing". Experts will skip this note anyway, but newcomers need strong advice from us. |
|
On second read, I think these changes are perfect. 👍 status: reviewed |
|
Thanks Javier! |
weaverryan
added a commit
that referenced
this pull request
Jul 10, 2016
…uiluz) This PR was submitted for the 2.3 branch but it was merged into the 2.7 branch instead (closes #6611). Discussion ---------- Discourage the use of controllers as services As briefly discussed during the past Docs Hack Day, the official Symfony opinion about "controllers as services" is very clear: don't do it, unless you know well what you are doing. I propose to remove most of the mentions to "controllers as services" to not confuse readers about something we don't want them to use. Commits ------- a1847fb Minor fix deaa5fc Fixed typo abc7cf3 Discourage the use of controllers as services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As briefly discussed during the past Docs Hack Day, the official Symfony opinion about "controllers as services" is very clear: don't do it, unless you know well what you are doing.
I propose to remove most of the mentions to "controllers as services" to not confuse readers about something we don't want them to use.